Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix analyze clustered index table can't trigger index primary #23254

Merged
merged 3 commits into from
Mar 11, 2021
Merged

planner: fix analyze clustered index table can't trigger index primary #23254

merged 3 commits into from
Mar 11, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com<!-- Thank you for contributing to TiDB!

PR Title Format:

  1. pkg [, pkg2, pkg3]: what's changed
  2. *: what's changed

-->

What problem does this PR solve?

Issue Number: close #23230

What is changed and how it works?

How it Works: only use analyze columns to handle analyze index primary when fast analyze int handle.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • none

@lzmhhh123
planner: fix analyze clustered index table can't trigger index primary
77320da 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123
fix
7f3e19e 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123 lzmhhh123 requested review from a team as code owners March 11, 2021 06:37
@lzmhhh123 lzmhhh123 requested review from XuHuaiyu and removed request for a team March 11, 2021 06:37
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2021
@lzmhhh123
Copy link
Contributor Author

/cc @tangenta @coocood

@github-actions github-actions bot added the sig/execution SIG execution label Mar 11, 2021
@ichn-hu ichn-hu mentioned this pull request Mar 11, 2021
Closed
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@coocood
Copy link
Member

coocood commented Mar 11, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@coocood
Copy link
Member

coocood commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f3e19e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot
Copy link
Member

@lzmhhh123: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@coocood coocood merged commit 22ff880 into pingcap:master Mar 11, 2021
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_analyze_cluster_index_primary branch March 26, 2021 06:59
@Rustin170506 Rustin170506 mentioned this pull request Oct 10, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@coocood coocood Awaiting requested review from coocood

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analyze primary index statement for clustered index table is not triggered
4 participants
@lzmhhh123 @tangenta @coocood @ti-chi-bot